Be simple, but not simpler

Pavel Filippov
4th of October, 2012

.self

Pavel Filippov (emdin)

blog.getbyid.com

Frontend dev @ Delivery Hero (aka Lieferheld.de),
world-wide food ordering platform, over 9 million orders placed)

Collaborative development

Github revolution:

• Pull requests
• + Comments
• = Great collaboration platform/forum
• (as in "respectful exchange of ideas and opinions")

Expectations

• Attitude
• Design
• Code
• Workflow

Attitude

• Be consistent
• Be fair
• Be lazy
• Be this wizard
• Boyscouts rule

Design

• Short classes and methods, short lines
  choose your limit and stick to it

  

Design

• Separate anonymous functions
  if it longer than one line. Embrace context changing (_bind)

  locationsCollection.fetch({
      success: function(collection, response) {
          throbber.hide();
          collection = collection.
            filterByRelevance(locationValue).
            sortByRelevance(locationValue);
          // ...more stuff...
      }
  });
            

  locationsCollection.fetch({ success: _.bind(this.onSuccess, this) });
            

Design

• Law of Demeter
  do not access internals of other object directly

  var lb = new Lightbox();
  lb.header = myHeader; // bad
  lb.setHeader(myHeader); // better
            

Design

• Stick to known patterns
  readability, clarity and predictability are more important than innovation and hacking

  smth || smth.do(); // neat
            

  if (smth) {
      smth.do(); // readable
  }
            

Code

• When in doubt, prefer wrappers over native methods and types (arrays and collections, indexOf, ...)
• No arguments about memory consumption and performance
• No stuff like window.location, raw ajax calls, all kind of low-levels APIs, sending headers, cookies, inline css+html code, recource paths
• No i18n and l10n specific data
• Tests are really there

Flow

• Commit history is clean and tells the story
• Embrace git rebase -i
• Reject simple merge
• Embrace git pull --rebase, rebase often, conflicts are healthy
• (Tip: comment on diffs, so they will persist after force push)

What we shouldn't care about (because it can be should be automated)

• Formatting
• Trailing commas (and other jslint features)
• Commented-out code
• Debug commands of all kinds
• Detailed documentation
• Test compliance (Travis!)

Travis integration awesomness

Need more code analysis tools

• UglifyJS.parser
• JSCoverage
• ...Is that all? What about complexity metrics?
  

  

Questions?

@emdin

Lieferheld.de